schedule: dp: (cosmetic) simplify a loop #9949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert a "while (1)" loop to a "do {} while (x)" loop to make the
termination condition explicit and deduplicate a function call.
Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lyakh
requested review from
LaurentiuM1234,
dbaluta,
marcinszkudlinski and
pblaszko
as code owners
marcinszkudlinski
approved these changes
Apr 3, 2025
Contributor
marcinszkudlinski
left a comment
marcinszkudlinski
left a comment
There was a problem hiding this comment.
at first version the while loop had no exit condition, thread used to be terminated by async abort. Break was introduced as a fix. "Do - while" does the same, a bit cleaner way.
Ship it!
lgirdwood
approved these changes
Apr 3, 2025
tmleman
approved these changes
Apr 7, 2025
dbaluta
approved these changes
Apr 7, 2025
serhiy-katsyuba-intel
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert a "while (1)" loop to a "do {} while (x)" loop to make the termination condition explicit and deduplicate a function call.